Open
Conversation
Validate that we can boot into recovery mode. Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is to avoid issue when the filepaths are changed. Anyway we have to find a more proper solution later. Signed-off-by: Loic Devulder <ldevulder@suse.com>
With `assert_script_run` it could be useful to keep `-f` option to curl. Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is to ensure that the ISO container image is validated before pushing it into the release manifest. A bsic OS boot is enough to validate the image and anyway we can't do more as installation cannot be done and user connection is not possible at this stage. Signed-off-by: Loic Devulder <ldevulder@suse.com>
a2c53b8 to
0d27f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple fixes/improvements:
add ISO container test
(re)add
-foption to curl when neededmake the filepaths more generic
add basic test for recovery mode
Related ticket: jsc#CORE-454 and jsc#CORE-543
Needles: To be added in osd directly, as my local lab has a different behavior with the needles
Verification run: OS Images tests, Release Manifests tests
Jobgroup update: Update openQA jobgroups SUSE/elemental#393
NOTE: the failures in
start_k8sare not because of this PR.NOTE 2: changes in the current Unified Core jobgroup will have to be done after merging this PR!